Fix Verk.Job decode/1 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should only care about job keys discarding any unknown keys. This is a safer implementation for users that schedule jobs to Verk using ruby Sidekiq::Client. A recent version of `newrelic_rpm` gem is injecting code into Sidekiq jobs for some sort of tracing/inspection making jobs scheduled with Sidekiq::Client invalid to Verk as they contain an unknown job key.
alissonsales
force-pushed
the
fix-job-decode
branch
from
ba7357e
to
d3b243f
Compare
|
@edgurgel thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should only care about
Verk.Jobstruct keys discarding any unknown keys.This is a safer implementation for users that schedule jobs to Verk
using ruby
Sidekiq::Client.A recent version of
newrelic_rpmgem is injecting code into Sidekiqjobs for some sort of tracing/inspection making jobs scheduled with
Sidekiq::Clientinvalid to Verk as they contain an unknown job key.