Selected text is very low contrast in light theme

[jojanzing]

Great implementation of the solarized theme, thank you!

Only one issue: selected text highlight is almost invisible while in the light theme, as the highlight colour barely differs from the background colour. In dark theme, selected text highlights as expected.

[edheltzel]

@jojanzing, could you send me a screenshot of the issue?

[pintergreg]

The pivot_table part is selected, which is indicated only by the visible white spaces. It is practically unusable for me in this way.

edit: I forgot to tell, that this happens only in a Jupyter notebook environment.

Version: 1.88.0
Commit: 5c3e652f63e798a5ac2f31ffd0d863669328dc4c
Date: 2024-04-05T09:25:05.142Z
Electron: 28.3.0
ElectronBuildId: undefined
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 6.8.5-arch1-1

[pintergreg]

Could be fixed using customization:

"workbench.colorCustomizations":{
  "notebook.editorBackground": "#eae0c0",
  "notebook.cellEditorBackground": "#fdf6e3"
},

[edheltzel]

Awesome, I can push this through a little later today or you're welcome to create a PR