-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unicode data to unicode 10.0.0 #13
Conversation
This originally was updating the data to Unicode 9, but since Unicode 10 is available, I updated the pull request to use those files instead |
A lot of tests are now failing. |
I don't think updating the Unicode data is causing the failures. The failing tests also fail when I try to run the tests from the current master branch (commit I ran the tests using |
I realized that I didn't run |
In Unicode 10, the long name alias of I think this will entail adding another lookup table build from PropertyAliases.txt and running property names through that before looking them up in the current tables. Should that be a part of this pull request or a separate one? |
I've added property aliasing, which fixed the test failure caused by the renamed property. |
The long name alias (effectively the main name) changed for STerm so Property Aliasing is needed to seamlessly support the change.
I'm still getting |
I get that failure when running the current master branch. It's caused by the fields starting on line 5183 in I've fixed the failures for |
The current unicode data is from 6.2.0, so this would add the new characters from the past 5 years, including over 350 new emoji.