Fixed a bug when using SBCL and latest trivial-gray-streams #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the failing tests mentioned in Issue #2. |
Closed
hanshuebner
added a commit
that referenced
this pull request
Oct 23, 2013
Fixed a bug when using SBCL and latest trivial-gray-streams
mv2devnul
added a commit
to mv2devnul/flexi-streams
that referenced
this pull request
Dec 9, 2013
Issue edicl#3: calling FILE-POSITION instead of STREAM-FILE-POSITION, per trivial-gray-streams maintainer request. Issue edicl#4: flexi-streams was not updating its notion of POSITION. Wanted to be defer handling of :start/:end to underlying stream, so the setter method of STREAM-FILE-POSITION calls FILE-POSITION (aka Issue edicl#3), then if that returns a non-nil value, calls FILE-POSITION to find what POSITION should be set to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug that surfaced due to changes in trivial-gray-streams.