Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding links if server responds with link and allow HTTP headers #57

Conversation

aiavci
Copy link

@aiavci aiavci commented Jan 4, 2022

Summary

This PR contains two additions:

  1. Allows user to override the hyperlink URL that is saved. This is especially important to

Commit history
Update src/index.js and README.md - Allow Overriding the link from a server response. Allow using headers in HTTP requests

Related issues
#55, #42, #20

Ali I. Avci added 2 commits January 4, 2022 11:41
@aiavci
Copy link
Author

aiavci commented Jan 4, 2022

Verified and tested dist. Can we merge and deploy this ASAP?

README.md Outdated Show resolved Hide resolved
@aiavci
Copy link
Author

aiavci commented Jan 4, 2022

@talyguryn Could we deploy this ASAP?

@talyguryn talyguryn merged commit d81e870 into editor-js:master Jan 4, 2022
@aiavci aiavci deleted the aavci/feature/add-link-response-and-http-headers branch January 4, 2022 10:11
@aiavci
Copy link
Author

aiavci commented Jan 4, 2022

Thank you 🙌

@aiavci
Copy link
Author

aiavci commented Jan 4, 2022

Sorry to have to do this. I just detected a typo. Please find a new PR for reference #58. I missed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants