Unset unset values

[piranna]

According to the spec, unset values should be considered as the definitions are not being provided in the .editorconfig file (they are "unset"), but reading the code, they are just only used as part of Typescript types. Is this on purpose so they can be passed down to the code using this library, or should they be filtered out so devs don't need to check for it explicitly? I think the second one... If so, I can create a quick PR for it.

[hildjj]

I think this is likely a bug. Will look at it.

[hildjj]

Wow. The tests are explicitly wrong.

https://github.com/editorconfig/editorconfig-core-test/blob/5ca0b296dc31124d0303895c163013450bd97958/filetree/CMakeLists.txt#L94

[hildjj]

editorconfig/editorconfig-core-test#12

[hildjj]

OK, I can do a couple of things:

• Give an unset() function that goes through the resulting property object removing anything with the value "unset"
• Add an unset property to ParseOptions that will call unset automatically at the end of processing
• Add a --unset flag to the CLI to set that property

I don't think I can make it the default, since "plugins" are supposed to be processing "unset"'s, according to the core devs.

Reactions?

[piranna]

Si, it's intended that unseted values have a values of unset instead of undefined, and I need to process unset values on my Code at application level, isn't It?

[piranna]

And yes, I've read both threads, and found that dumb :-(

[hildjj]

And yes, I've read both threads, and found that dumb :-(

Same here. Anyway, I'm going to land this "fix" for you, and push out 2.0.