Fixed Social Links Icons (#503)

edly-io · Jan 31, 2024 · 214444a · 214444a
1 parent 187cf86
commit 214444a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lms/static/sass/features/_learner-profile.scss b/lms/static/sass/features/_learner-profile.scss
@@ -404,7 +404,7 @@
         margin: 0 $baseline/2;
 
         .social-links {
-          @include padding($baseline/4, 0, 0, $baseline/4);
+          @include padding($baseline/2, 0, 0, 0);
 
           font-size: 2rem;
 

diff --git a/openedx/features/learner_profile/static/learner_profile/templates/social_icons.underscore b/openedx/features/learner_profile/static/learner_profile/templates/social_icons.underscore
@@ -1,8 +1,13 @@
 <div class="social-links">
     <% for (var platform in socialLinks) { %>
         <% if (socialLinks[platform]) { %>
-            <a rel="noopener" target="_blank" href= <%-socialLinks[platform]%>>
-                <span class="icon fa fa-<%-platform%>-square" data-platform=<%-platform%> aria-hidden="true"></span>
+            <a rel="noopener" target="_blank" href="<%- socialLinks[platform] %>">
+                <span class="<%- 
+                platform === 'facebook' ? 'fab fa-facebook-f' : 
+                platform === 'twitter' ? 'fab fa-x-twitter' : 
+                platform === 'linkedin' ? 'fab fa-linkedin' : 
+                'icon fa fa-' + platform + '-square' %>" data-platform="<%- platform %>" aria-hidden="true">
+                </span>
             </a>
         <% } %>
     <% } %>