Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow forum app to use Forum V2 APIs #575

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

Ali-Salman29
Copy link

Description

Added a setting FORUM_V2_REGEXS. It contains regex patterns for matching ForumV2 app URLs. The application will use the ForumV2 APIs if a ForumV1 URL matches any of these regex patterns. This setting is intended to help route traffic to the appropriate version of the Forum API based on the structure of the URL.

Copy link

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Updated settings to use Forum v2. All requests will be handled by Forum v2.
The Forum v2 includes a proxy for redirecting all requests to the CS Commerce app
that are not implemented within Forum v2. This ensures that any unhandled requests
are appropriately forwarded, maintaining seamless integration with the CS Commerce application.
@Ali-Salman29 Ali-Salman29 merged commit a480618 into forum_v2 Aug 10, 2024
42 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants