LOAN-147 #comment - Merged LoanParties and LoanGuaranties into LoanCore and MortgageLoans #924

ElisaKendall · 2020-03-08T20:52:05Z

Signed-off-by: Elisa Kendall ekendall@thematix.com

Description

With this resolution, we've eliminated duplicate terms in LoanParties and LoanGuaranties as well as in LoansAppraisal; merged relevant elements into either LoanCore or MortgageLoans; also further cleaned up LoanCore to eliminate contact details which are now available in FND.

Fixes: #923 / LOAN-147

Checklist:

I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
My contribution follows the principles of best practices for FIBO.
My changes have been reconciled with latest master and no merge conflicts remain.
This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
Hygiene tests have been applied by a PR with "(WIP)" in title.
The issue has been tested locally using a reasoner (for ontology changes).

…nGuaranties as well as in LoansAppraisal; merged relevant elements into either LoanCore or MortgageLoans; cleaned up LoanCore to eliminate contact details which are now available in FND Signed-off-by: Elisa Kendall <ekendall@thematix.com>

rivettp

I made a few comments but most relate to the originals and I'd be OK with deferring them; though think we should take this opportunity of fixing the various classes and properties around MIG to avoid changing the URIs again soon after.

rivettp · 2020-03-08T23:48:35Z

LOAN/LoanContracts/LoanCore.rdf

@@ -261,6 +253,14 @@
 		<skos:definition>loan or extension of credit in which the loan principal cannot be increased after funds are dispersed and the loan is partially repaid</skos:definition>
 	</owl:Class>

+	<owl:Class rdf:about="&fibo-loan-ln-ln;Comaker">


I think "co-maker" is a lot more prevalent. I'd make that the primary and comaker a synonym

Puzzled you omitted the hyphen from the URI - that's a legal character.

For naming conventions, we've been following the typical Semantic Web approach of not including any hyphens, underscores, etc. in names, but include proper punctuation in labels, aside from individuals.

LOAN/LoanTypes/MortgageLoans.rdf

LOAN/LoanTypes/SecuredLoans.rdf

…hings up a bit more Signed-off-by: Elisa Kendall <ekendall@thematix.com>

rivettp · 2020-03-09T15:49:02Z

LOAN/LoanContracts/LoanCore.rdf

@@ -633,14 +573,14 @@
 		</rdfs:subClassOf>
 		<rdfs:subClassOf>
 			<owl:Restriction>
-				<owl:onProperty rdf:resource="&fibo-loan-ln-ln;hasOriginatorCompany"/>
+				<owl:onProperty rdf:resource="&fibo-loan-ln-ln;hasOriginatingServiceProvider"/>


I thought we were trying to avoid including the names of range classes in properties. Why not hasOriginator?

In mortgage lending, the originator often refers to the individual banker, so I did not want to change the meaning of what MU had - if you look at the ontology, he distinguished between originating company and person for that reason. The definitions need work, as do property names, and if we follow some of our other patterns, we could have 3 properties - hasOriginator, hasOriginatingServiceProvider, and hasOriginatingIndividual or something like that - which includes the license. The terminology here needs work, and should be moved to a US specific ontology, but we'll have to account for the fact that originator often refers to the licensed individual.

rivettp · 2020-03-09T15:49:42Z

LOAN/LoanContracts/LoanCore.rdf

 							</rdf:Description>
 							<owl:Restriction>
-								<owl:onProperty rdf:resource="&lcc-lr;has"/>
+								<owl:onProperty rdf:resource="&lcc-lr;isIdentifiedBy"/>


Too US-specific

Yes - for another pass.

rivettp · 2020-03-09T15:58:04Z

LOAN/LoanContracts/LoanCore.rdf

-		<rdfs:label>phone number</rdfs:label>
-		<skos:definition>a virtual address for communication via phone</skos:definition>
-		<skos:editorialNote>Future consideration: move this property to Addresses ontology (fibo-fnd-plc-adr).</skos:editorialNote>
+		<fibo-fnd-utl-av:explanatoryNote>Similar to a PaymentSchedule except that the dates and amounts are actuals.</fibo-fnd-utl-av:explanatoryNote>


PaymentHistory should be dated. Especially with hasOutstandingAmount (which should be a property of the Loan not the History).
More practically we should be able easily to turn a Schedule into a History.

Yes - for another issue

rivettp · 2020-03-09T16:03:09Z

LOAN/LoanContracts/LoanCore.rdf

 		<rdfs:subClassOf>
 			<owl:Restriction>
 				<owl:onProperty rdf:resource="&fibo-loan-ln-ln;hasCreditLimit"/>
 				<owl:someValuesFrom rdf:resource="&fibo-fnd-acc-cur;MonetaryAmount"/>
 			</owl:Restriction>
 		</rdfs:subClassOf>
-		<rdfs:label>reverse mortgage loan contract</rdfs:label>
+		<rdfs:label>reverse mortgage</rdfs:label>
 		<skos:definition>a mortgage contract that pays out money to the borrower against a set principal limit that is based on the value of existing equity in the underlying collateral.</skos:definition>
 		<fibo-fnd-utl-av:explanatoryNote>A reverse mortgage and an open end loan both have a credit limit.</fibo-fnd-utl-av:explanatoryNote>
 		<fibo-fnd-utl-av:explanatoryNote>The interest is added to the principal balance.</fibo-fnd-utl-av:explanatoryNote>


The note does not make much sense from a FIBO point of view.

Ok - we need to do several more passes on this in any case

rivettp

Remaining comments are minor.

rivettp · 2020-03-09T16:15:18Z

LOAN/LoanContracts/LoanCore.rdf

+				</owl:intersectionOf>
+			</owl:Class>
+		</rdfs:range>
+		<skos:definition>relates something, typically a loan contract, to the service provider responsible for originated the loan</skos:definition>


"originated" should be "originating", but it's somewhat circular in leaving "originate" undefined.

rivettp · 2020-03-09T16:16:04Z

LOAN/LoanContracts/LoanCore.rdf

-		<rdfs:label>has originator company</rdfs:label>
-		<rdfs:range rdf:resource="&fibo-fnd-org-org;Organization"/>
-		<skos:definition>relates something, typically  a loan contract, to the  company affilliated with the person originating the loan</skos:definition>
+	<owl:ObjectProperty rdf:about="&fibo-loan-ln-ln;hasOriginatingServiceProvider">


should not include the range in the property name

rivettp · 2020-03-09T16:21:29Z

LOAN/LoanTypes/MortgageLoans.rdf

-		<rdfs:subClassOf rdf:resource="&fibo-loan-ln-ln;MortgageLoanContract"/>
-		<rdfs:label xml:lang="en">investment home loan contract</rdfs:label>
-		<owl:disjointWith rdf:resource="&fibo-loan-typ-mtg;SecondHomeLoanContract"/>
+		<owl:disjointWith rdf:resource="&fibo-loan-typ-mtg;SecondHomeLoan"/>


The disjointness does not make sense when the definition includes "second property". Is it not possible for a property to be purchased both for vacation use and as an investment?

rivettp · 2020-03-09T16:23:18Z

LOAN/LoanTypes/MortgageLoans.rdf

 			</owl:Restriction>
 		</rdfs:subClassOf>
+		<rdfs:label xml:lang="en">mortgage indemnity guarantee</rdfs:label>


Add abbreviation of MIG

rivettp · 2020-03-09T16:27:42Z

LOAN/LoanTypes/MortgageLoans.rdf

@@ -195,61 +192,18 @@
 	</owl:Class>

 	<owl:Class rdf:about="&fibo-loan-typ-mtg;SecondHomeLoan">
-		<rdfs:subClassOf rdf:resource="&fibo-loan-typ-mtg;MortgageLoan"/>
+		<rdfs:subClassOf rdf:resource="&fibo-loan-ln-ln;Mortgage"/>
 		<rdfs:label xml:lang="en">second home loan</rdfs:label>
 		<skos:definition xml:lang="en">A loan which may be used for a vacation home or second home used for personal reasons.</skos:definition>


how does this relate to MortgageLoanPurpose?

rivettp · 2020-03-09T16:31:59Z

LOAN/LoanTypes/SecuredLoans.rdf

@@ -68,17 +75,17 @@
 	</owl:Class>

 	<owl:Class rdf:about="&fibo-loan-typ-sec;GuaranteedLoan">
-		<rdfs:subClassOf rdf:resource="&fibo-loan-typ-sec;SecuredLoan"/>
+		<rdfs:subClassOf rdf:resource="&fibo-loan-ln-ln;SecuredLoan"/>


(thought I made this comment already with a reference)
I think this is wrong: secured and guaranteed are orthogonal.

trypuz added LOAN Loans Domain consistency About overall consistency labels Mar 8, 2020

trypuz added this to the 2020 Q1 FIBO Release milestone Mar 8, 2020

trypuz requested review from mereolog, jziemer2 and uscholdm March 8, 2020 22:41

rivettp previously approved these changes Mar 9, 2020

View reviewed changes

LOAN-147 #comment - additional revisions to address feedback, clean t…

538331e

…hings up a bit more Signed-off-by: Elisa Kendall <ekendall@thematix.com>

ElisaKendall dismissed rivettp’s stale review via 538331e March 9, 2020 03:42

rivettp reviewed Mar 9, 2020

View reviewed changes

rivettp mentioned this pull request Mar 9, 2020

GuaranteedLoan should not be a subclass of SecuredLoan #927

Closed

rivettp approved these changes Mar 9, 2020

View reviewed changes

dsnewman approved these changes Mar 10, 2020

View reviewed changes

dallemang merged commit cb6549d into edmcouncil:master Mar 10, 2020

ElisaKendall deleted the LOAN-147 branch March 10, 2020 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LOAN-147 #comment - Merged LoanParties and LoanGuaranties into LoanCore and MortgageLoans #924

LOAN-147 #comment - Merged LoanParties and LoanGuaranties into LoanCore and MortgageLoans #924

ElisaKendall commented Mar 8, 2020

rivettp left a comment

rivettp Mar 8, 2020

ElisaKendall Mar 9, 2020

rivettp Mar 9, 2020

ElisaKendall Mar 9, 2020

rivettp Mar 9, 2020

ElisaKendall Mar 9, 2020

rivettp Mar 9, 2020

ElisaKendall Mar 9, 2020

rivettp Mar 9, 2020 •

edited

Loading

ElisaKendall Mar 9, 2020

rivettp Mar 9, 2020

ElisaKendall Mar 9, 2020

rivettp left a comment

rivettp Mar 9, 2020

rivettp Mar 9, 2020

rivettp Mar 9, 2020

rivettp Mar 9, 2020

rivettp Mar 9, 2020

rivettp Mar 9, 2020

LOAN-147 #comment - Merged LoanParties and LoanGuaranties into LoanCore and MortgageLoans #924

LOAN-147 #comment - Merged LoanParties and LoanGuaranties into LoanCore and MortgageLoans #924

Conversation

ElisaKendall commented Mar 8, 2020

Description

Checklist:

rivettp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rivettp Mar 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rivettp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rivettp Mar 9, 2020 •

edited

Loading