-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
161 Add ontological modules generation #166
Conversation
Signed-off-by: Rafał Trójczak <rafal@trojczak.pl>
Signed-off-by: Rafał Trójczak <rafal@trojczak.pl>
If I took the pizza ontology and used it in the viewer would it generate the modules by itself? Or test it in another way? |
Yes, indeed. It should display all loaded ontologies as a flat list of modules. The only requirement is that this ontology should have a defined ontology label. |
onto-viewer seems to ignore all files with the ttl extension - it loads only .rdf files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments above.
@mereolog Yes, indeed Turtle files are ignored but this was always the case. If we want to support other types of serialization I propose to create a separate issue for that matter. |
For the GAO ontology, a module is created that contains the ontology and an empty module named "owl". |
@patrycjamia Ontologies have to have |
Details of some ontologies can't be displayed because the IRIs of these ontologies don't end with |
@mereolog I propose to create a new issue to change the way how ontologies are looked for within the application. For now, the logic is as follows: there is one endpoint for obtaining both ontologies and different types of entities; it is assumed that an ontology has an IRI ending with |
Signed-off-by: Rafał Trójczak <rafal@trojczak.pl>
Different icons are displayed for "modularized ontologies": Perhaps this one is for @dasawanaka or @patrycjamia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a difference between the current prod and this PR - here is an example.
https://www.omg.org/spec/LCC/Countries/CountryRepresentation/ displayed in prod:
https://www.omg.org/spec/LCC/Countries/CountryRepresentation/ displayed in PR-166:
First, the LCC ontologies should not be displayed at all because they are imported and not stored in FIBO.
Secondly, an ontology without maturity level should not be assumed to be provisional - we should assume fibo-fnd-utl-av:Informative for them.
Signed-off-by: Rafał Trójczak <rafal@trojczak.pl>
@mereolog, @patrycjamia, @dasawanaka I've updated PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When load pizza ontology, viewer generate one module 'pizza', but when i try to click it, it shows info Not found element in ontology with IRI
. For pizza doesn't work any graph...
@mereolog, If it is for new issue i will accept pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dasawanaka @patrycjamia Your problems are related to the fact that in the current form the OV can only find an ontology when its IRI ends with |
Signed-off-by: Rafał Trójczak <rafal@trojczak.pl>
Signed-off-by: Rafał Trójczak rafal@trojczak.pl