Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup changesets #2

Closed
wants to merge 3 commits into from
Closed

chore: setup changesets #2

wants to merge 3 commits into from

Conversation

edmundhung
Copy link
Owner

Background

Currently both the adapter and resolver package depends on conform-dom but in a slightly different way:

  • conform-react list conform-dom as dependency
  • conform-zod has a peerDependency on conform-dom

The main idea behind is to:

  1. Allow users to use conform-react independently without the need to install another package, while
  2. Share the conform-dom dependency with the resolver package when using them together

While using fixed version on all packages can simplify the process, this might make it less favourable to introduce breaking changes without batching them together and thus making the release life-cycle longer.

Status quo: On-hold

Although I would love to automate the release process as early as possible, changesets will always bump the major version of the resolver package due to the peerDependency setup.

This behaviour is too aggressive even with the onlyUpdatePeerDependentsWhenOutOfRange experimental flag. Since a minor version bumped on conform-dom will trigger a major version bumped on conform-zod.

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2022

🦋 Changeset detected

Latest commit: 29edac4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@conform-to/react Patch
@conform-to/zod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung edmundhung mentioned this pull request Jul 6, 2022
17 tasks
@edmundhung edmundhung changed the title Setup changesets chore: setup changesets Jul 7, 2022
@edmundhung edmundhung closed this May 29, 2023
@edmundhung edmundhung deleted the setup-changeset branch November 8, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant