Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get list of interfaces to implement. #5

Closed
orlovm opened this issue Jun 10, 2022 · 10 comments · Fixed by #6
Closed

Cannot get list of interfaces to implement. #5

orlovm opened this issue Jun 10, 2022 · 10 comments · Fixed by #6

Comments

@orlovm
Copy link

orlovm commented Jun 10, 2022

I've installed goimpl.nvim via vim-plug and registered it as telelescope extension.

When I try to use it with lua require'telescope'.extensions.goimpl.goimpl{}, I get this notification:
[telescope.filter_symbols]: interface symbol(s) were not part of the query results

I have neovim 0,7. And the latest versions of all dependencies listed in readme.
And gopls configured and working correctly.

Please, tell me what I'm doing wrong. Plugin looks very usefull!

@Cih2001
Copy link
Contributor

Cih2001 commented Jun 28, 2022

Hey,

f3d1109 not only didn't fix the issue, but also broke the extension for me. I had to revert it.

@Cih2001 Cih2001 mentioned this issue Jun 28, 2022
@edolphin-ydf
Copy link
Owner

please try the newest main branch.

@edolphin-ydf
Copy link
Owner

tested with newest telescope

@Cih2001
Copy link
Contributor

Cih2001 commented Jul 4, 2022

There are still problems with it. There are times when your symbol list is not empty, but does not contain any interfaces. If you enter a character like q in the search box, such a case will occur. My PR (#6) fixes this problem by manually filtering out interfaces rather than using utils.filter_symbols
Screenshot from 2022-07-04 18-33-47

edolphin-ydf added a commit that referenced this issue Jul 5, 2022
edolphin-ydf added a commit that referenced this issue Jul 5, 2022
edolphin-ydf added a commit that referenced this issue Jul 5, 2022
@edolphin-ydf edolphin-ydf reopened this Jul 5, 2022
@edolphin-ydf
Copy link
Owner

Ok. I got you. And there is some conflict, let me fix it.

edolphin-ydf added a commit that referenced this issue Jul 5, 2022
@edolphin-ydf
Copy link
Owner

Done

@edte
Copy link

edte commented Jul 5, 2022

I also encountered a similar problem, there are some interfaces that won't show up
image

Only a few interfaces are displayed
image

Plugins are up to date

@edolphin-ydf
Copy link
Owner

I also encountered a similar problem, there are some interfaces that won't show up image

Only a few interfaces are displayed image

Plugins are up to date

Have no idea on this.
I'v test on two project, a simple test project And a large project.
In the simple test project, everything works fine.
But in the large project, i'v met the same issue with you.
After some debug, i found that the lsp returned with missing some interfaces. So it's maybe the lsp's issue.

@edolphin-ydf
Copy link
Owner

@edte I'v found a new way to get what you want. See this document
use the exact feature in the query

Character Usage Match
' 'abc exact
^ ^printf exact prefix
$ printf$ exact suffix

eg:
'Reader

@edte
Copy link

edte commented Jul 6, 2022

it's work fine,thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants