fix: kebab case pod name on kubectl run

edosrecki · Jan 11, 2023 · e5253fe · e5253fe
1 parent 13b0e82
commit e5253fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/lib/configurations/index.ts b/src/lib/configurations/index.ts
@@ -1,5 +1,5 @@
 import exitHook from 'exit-hook'
-import { omit } from 'lodash'
+import { omit, kebabCase } from 'lodash'
 import {
   deletePod,
   portForward,
@@ -40,7 +40,7 @@ export const deleteConfiguration = (configuratioName: string): void => {
 
 export const execConfiguration = (configuration: Configuration) => {
   const pod = {
-    name: `sql-proxy-${configuration.configurationName}-${randomString()}`,
+    name: `sql-proxy-${kebabCase(configuration.configurationName)}-${randomString()}`,
     context: configuration.kubernetesContext,
     namespace: configuration.kubernetesNamespace,
     serviceAccount: configuration.kubernetesServiceAccount,

diff --git a/src/lib/updates.ts b/src/lib/updates.ts
@@ -15,7 +15,7 @@ export const notifyForUpdates = () => {
     updateCheckInterval: oneDayMs,
   })
 
-  if (update) {
+  if (update && update.current !== update.latest) {
     const text =
       `${yellow(update.current)} ↦ ${green(update.latest)}\n\n` +
       `${blue('brew')} upgrade ${name}\n` +