Add new line and arrow icons #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iza-pik
requested review from
zac-robinson,
martinmcneela and
ChrissyABrown
as code owners
zac-robinson
approved these changes
Jul 15, 2022
|
Not worried for this PR, but in future can we just add any new icons to the end of the lists? If you look at the builds in chromatic, it is confused because the change was in the middle and so it looks like all the other icons changed too :) |
Ah, sorry about this, I was trying to get it next to the old line and didn't know it confused the builds. I'll remember for next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE CREATING THIS PR, have you bumped the package JSON where appropriate? Yes, v1.1.11
Ticket / Why this is needed: Related to new line tool work: https://edozohq.atlassian.net/browse/MAPS-2004
Link to Figma doc: https://www.figma.com/file/bWhvO6OYYKojDEhoSPB841/Maps---Arrow-Tool-Re-Work-%2BTextRotation?node-id=12%3A13605