Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode Electron "launch" debugger config does not work with externals in renderer process bundle #36

Closed
danielweck opened this issue Jan 24, 2018 · 1 comment
Closed

VSCode Electron "launch" debugger config does not work with externals in renderer process bundle #36

danielweck opened this issue Jan 24, 2018 · 1 comment

Comments

@danielweck
Copy link
Member

There's a weird "bug" (feature?) in the Electron CLI, whereby electron . (assuming package.json and a correct main property pointing to dist/main.js) is different than electron dist/main.js. The former works great, the latter breaks when Electron renderer process is launched from a code bundle that contains Node CommonJS require() calls to externalized packages.
Unfortunately, the VSCode launch configuration results in the latter. Thankfully, we can fix that by using an "attach" configuration to an existing Electron process.
danielweck added a commit that referenced this issue Jan 24, 2018
@danielweck
Electron "attach" launch configuration to handle renderer process bun…
9b3a8d1 
…dles that contain external package references, see #36
@danielweck
Copy link
Member Author

Fixed via 9b3a8d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck