update progression bar to show global percentage of the book #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill also exclude null and empty string
…pends on files, but most are zero-based index and this is currently broken), need to check divina and audiobooks too
panaC
approved these changes
May 23, 2024
|
I let Daniel to merge |
|
Hi Arthur, I am taking over this PR as the test matrix is quite extensive and we know from experience that the zero-based versus one-based indexing is tricky (I spotted a PDF bug in my tests). Need to test Divina (continuous or not), Audiobooks, EPUB reflow, EPUB FXL, and PDF with different types of "pagination" (virtual or physical) |
…ill cannot be linked into from progression bar click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2320