-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-flow PR for test #7
Conversation
@AmitManna99 , We don't want this part to be removed, I have tested your code and I can't see this part. Please look into it. Also don't remove the left side bar that contains the outline. Before removing any feature or portion from the existing code, let us know first. |
@Abhijit2505 , Actually I did remove any left side bar. I just modified its look. Also, I putted sidenav code into a new file which will be retrieve by JS. It will reduce the repetition of code. I also putted a right side bar. 1. Left Sidebar for Website Outline I just removed the section you mentioned in the picture because people can directly go to the page through the left side nav. (Instead of clicking on the nav which scroll the page, then click again on the item. That increases the number of click.) Although I can bring the section back if you want. |
Great, but these parts of the page were not visible in my local server, are
there any specific dependencies that I should know about?
…On Fri, Dec 18, 2020 at 3:31 PM Amit Manna ***@***.***> wrote:
@Abhijit2505 <https://github.com/Abhijit2505> , Actually I did remove any
left side bar. I just modified its look. Also, I putted sidenav code into a
new file which will be retrieve by JS. It will reduce the repetition of
code.
I also putted a right side bar.
*1. Left Sidebar for Website Outline 2. Right Sidebar for In-Page Outline*
[image: Screenshot 2020-12-18 150637]
<https://user-images.githubusercontent.com/54736237/102600603-0c4f3b00-4145-11eb-8b43-2439159d1b19.png>
I just removed the section you mentioned in the picture because people can
directly go to the page through the left side nav. (*Instead of clicking
on the nav which scroll the page, then click again on the item. That
increases the number of click.*) Although I can bring the section back if
you want.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMSO4W7XYAAU45AH3Y7F47DSVMSBBANCNFSM4U4THX4A>
.
|
I have cloned your repo and hosted it in my local server, the right side is visible but the left side rendered by JS is not. See the website is hosted with GitHub pages, so is there any more dependencies I should know about? I am taking two of our web developers in loop @amoghpete @himanshu-0624 for this issue. |
This reverts commit a45e297.
No description provided.