Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-flow PR for test #7

Closed
wants to merge 27 commits into from
Closed

Conversation

AmitManna99
Copy link
Contributor

No description provided.

@Abhijit2505
Copy link
Member

Capture eduAlgo Doc

@AmitManna99 , We don't want this part to be removed, I have tested your code and I can't see this part. Please look into it. Also don't remove the left side bar that contains the outline.

Before removing any feature or portion from the existing code, let us know first.

@AmitManna99
Copy link
Contributor Author

@Abhijit2505 , Actually I did remove any left side bar. I just modified its look. Also, I putted sidenav code into a new file which will be retrieve by JS. It will reduce the repetition of code.

I also putted a right side bar.

1. Left Sidebar for Website Outline
2. Right Sidebar for In-Page Outline

Screenshot 2020-12-18 150637

I just removed the section you mentioned in the picture because people can directly go to the page through the left side nav. (Instead of clicking on the nav which scroll the page, then click again on the item. That increases the number of click.) Although I can bring the section back if you want.

@Abhijit2505
Copy link
Member

Abhijit2505 commented Dec 18, 2020 via email

@AmitManna99
Copy link
Contributor Author

I moved this section to a new file navbar.html and created a separated sidenav.css file file.

This is the file structure I have in my local server linked to each other.

Screenshot 2020-12-18 165005

@Abhijit2505
Copy link
Member

Abhijit2505 commented Dec 21, 2020

Capture bb

I have cloned your repo and hosted it in my local server, the right side is visible but the left side rendered by JS is not. See the website is hosted with GitHub pages, so is there any more dependencies I should know about?

I am taking two of our web developers in loop @amoghpete @himanshu-0624 for this issue.

@Abhijit2505 Abhijit2505 added enhancement New feature or request In-review The PR/issue is under review labels Dec 21, 2020
@Abhijit2505 Abhijit2505 closed this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In-review The PR/issue is under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants