Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achieve NPM compatibility #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChunxuTang
Copy link

Hi,

The original tracking.js library does not support NPM modules well, and it's difficult to directly use it in Node.js or front-end ES6 development. I added some code to export tracking, eye, face, and mouth (three object classifiers) objects in CommonJS modules. In this case, tracking.js will be totally NPM compatible.

The original examples are kept intact, and all tests pass.

Any ideas about the PR? Thank you.

@ChunxuTang
Copy link
Author

ChunxuTang commented Jul 19, 2017

In the check of Travis CI, an error occurs:

/home/travis/build/eduardolundgren/tracking.js/node_modules/runsequence/node_modules/chalk/index.js:2
const escapeStringRegexp = require('escape-string-regexp');
^^^^^

SyntaxError: Use of const in strict mode.

...

Maybe the version of Node.js need to be upgraded on Travis CI? Could anyone help me to check it?

I have just sent a new PR trying to solve the problem. #237

@zenorocha
Copy link
Collaborator

That's awesome! We definitely need to be more npm-friendly.

@@ -236,6 +236,8 @@
var width;
var height;


// FIXME here the video display size of the analysed size
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaTang please drop these comments fro this PR.

@saghul
Copy link

saghul commented Jul 21, 2017

Hi everyone, I'm @JoshuaTang's Google Summer of Code mentor, and we are in the process of using your library for face detection in Jitsi Meet. Here is his work so far, for the curious: jitsi/jitsi-meet#1666

He also made several other improvements which he'll be making PRs for shortly.

Thanks a lot for making the library available and I hope our contributions can be incorporated in the project.

Cheers!

@saghul
Copy link

saghul commented Jul 21, 2017

@JoshuaTang Please make a commit updating the travis file, using Node 6 as the runtime, since that's the current LTS version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants