Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improved headers and cookies #9

Merged
merged 12 commits into from
Jun 21, 2023

Conversation

GThurler
Copy link
Contributor

  • Added cookie arguments to all functions, so we can use the --cookie flag in curl
  • Added an override to the hard-coded application/json content type header, since some servers expect proprietary extra parameters to this value, e.g.: application/json;enp
  • Implemented a CurtHttpHeaders class to store response headers in the same way the SDK's io package does, storing multiple values for each header - this was not an option in the http package's Request class since it uses a Map<String, String>.
  • Implemented a CurtResponse class to replace the current usage of the Response class from http package - it behaves the same way we were using it, with added cookies 🍪

@edufolly edufolly merged commit b3f5cf2 into edufolly:dev Jun 21, 2023
@GThurler GThurler deleted the feature/improved-headers-and-cookies branch June 21, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants