Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNLP file should use the complete URL as href #18

Closed
frosch95 opened this issue Jul 28, 2016 · 4 comments
Closed

JNLP file should use the complete URL as href #18

frosch95 opened this issue Jul 28, 2016 · 4 comments

Comments

@frosch95
Copy link

Not using the complete url as href fails, when downloading JNLP file and double click it. More and more browsers are not supporting java and webstart directly.
When double clicking the jnlp file, webstart tries to find the dependencies locally, where no fxlauncher.jar exists, when loaded from webserver.

As you have the url in the settings, you could easily add them to the JNLP file, like
<jnlp ... href="**http://javafx.ninja/smartcsv/**SmartCSV.fx.jnlp">

@edvin
Copy link
Owner

edvin commented Jul 28, 2016

The JNLP file is created by the javapackager command, and generally you don't use it since you would distribute the binary installer instead. If we however could add some more parameters to javapackage to make it create a valid JNLP file that would certainly be a bonus.

Information about possible parameters are here:

https://docs.oracle.com/javase/8/docs/technotes/tools/unix/javapackager.html

@edvin
Copy link
Owner

edvin commented Jul 28, 2016

It doesn't seem like javapackager supports this, but we could of course modify the JNLP file after it has been created. By the way, this is outside the scope of fxlauncher, since it doesn't use javapackager or support WebStart (it is an alternative after all), but we could certainly make the Gradle plugin support JNLP file modifications.

@frosch95
Copy link
Author

I haven't worked with the javapacker, so I have no idea how to fix this. Just realized the effect :-)
Is it better to report this kind of issues at the gradle plugin project?

Thanks,
Andi

@edvin
Copy link
Owner

edvin commented Aug 17, 2016

Same with this - since FXLauncher was not meant to run under webstart, I'll close this as well :)

@edvin edvin closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants