Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: show better error messages when update step or startup fails #40

Closed
ChrisLMerrill opened this issue Nov 30, 2016 · 6 comments
Closed

Comments

@ChrisLMerrill
Copy link

I ran into two separate problems where the error shown to the end-user is unfriendly and/or inaccurate.

  1. download permissions prevented download of the manifest
  2. download permissions prevented download of a jar

In both cases, the reported error was a ClassNotFoundException. The download failure was apparently ignored and fxlauncher attempted to run the program even though it had been unable to download the resources.

The desired outcome would be to tell the end-user that the update had failed (unable to get manifest or unable to get required resources) and perhaps mention the HTTP status 403 code when that is the culprit. A stacktrace is, IMO, unfriendly to the end user. Being unable to reach the server at all, as one might get when running offline, should be acceptable if all the resources are present to run the app.

Even when the update succeeds, if the target app terminates abnormally, a stacktrace should not be shown to the end user - they should simply be told that there was a failure and directed to the diagnostic log...and possibly an application-specific URL for getting help from the app developer.

@edvin
Copy link
Owner

edvin commented Dec 9, 2016

Sorry for the late reply. I'm swamped with writing documentation for TornadoFX and stuff at work, so I have to put this on the back burner. I'll get to it as soon as possible.

@ronsmits
Copy link
Collaborator

@edvin The problem is that the launcher uses two try catches 1 to update and 1 to launch if we make it 1 try/catch then the app will not be launched if something went wrong.

If you agree I will change that.

@edvin
Copy link
Owner

edvin commented Feb 20, 2017

Ideally I'd like the app to continue running even if update cannot be performed. If not, maybe a config setting for this?

@ronsmits
Copy link
Collaborator

config setting is easy, I will push it either tonight or tomorrow

@edvin
Copy link
Owner

edvin commented Feb 20, 2017

Great Ron, thanks a lot :))

@edvin
Copy link
Owner

edvin commented Mar 9, 2018

This was implemented, so I'm closing the issue :)

@edvin edvin closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants