Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should fail of gcloud fail #15

Open
HazemKhaled opened this issue Nov 20, 2019 · 2 comments
Open

Should fail of gcloud fail #15

HazemKhaled opened this issue Nov 20, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@HazemKhaled
Copy link

Currently shell.exec('gcloud') error not handled, so whatever happens while deploy it give me success instead of fail, so my CI deployment trigger never work.

Example

ERROR: (gcloud.app.deploy) Permissions error fetching application [apps/my-project]. Please make sure you are using the correct project ID and that you have permission to view applications on the project.
Build finished successfully!.

Another example

ERROR: (gcloud.app.deploy) User [my-project@appspot.gserviceaccount.com] does not have permission to access app [my-project] (or it may not exist): App Engine Admin API has not been used in project 934221695787 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/appengine.googleapis.com/overview?project=1234567890 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
- '@type': type.googleapis.com/google.rpc.Help
  links:
  - description: Google developers console API activation
    url: https://console.developers.google.com/apis/api/appengine.googleapis.com/overview?project=934221695787
Build finished successfully!.
@HazemKhaled
Copy link
Author

I think it should be handled here, I'll try to create pull request soon
https://github.com/EducationLink/meteor-google-cloud/blob/master/src/lib/google.js#L92

@raphaelarias
Copy link

That's great, makes perfect sense. Pull requests are welcomed, otherwise it will add error handling. I'm going to release a new version soon, we can include this improvement.

@raphaelarias raphaelarias self-assigned this Nov 26, 2019
@raphaelarias raphaelarias added the enhancement New feature or request label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants