Changed the filling to inpaint #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnunm
reviewed
Jun 30, 2021
There was a problem hiding this comment.
This works great now for images like Only-Carol-Dress_383296_65_extra1, very cool! 😄
I think this PR solves issue #6, the problem when the product goes outside both the top and bottom edge is a lot more complicated, so I think that should be a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the functionality of pad_to_fill() to fill based on the image contents instead of the most common color. This should solve #6 . Does behave wierdly on Adidas-Terrex-Trail-LS-T-shirt_484421_48_extra7.jpg and other instances where the image extends both the top and bottom. It also somewhat slows down when there is a lot to paint in.