Ejh d7 #8
Draft
Ejh d7 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update post document
update write grid comp document
…m wrong for nests (NOAA-EMC#806) * nesting fixes 1. Initialize hailwat index in dynamical core. 2. Use the correct tile number for nests in atmos_model.F90. * remove unneeded write statements * Fix kchunk3d in io/module_write_netcdf.F90 --------- Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
* Update atmos_cubed_sphere and add compile definition BYPASS_BREED_SLP_INLINE to dycore * Pass correct mpi communicator type to post_alctvars routine in inline post
* Update github workflow. Update gcc to 12 and mpi to openmpi * Add 'spack clean' to reduce the size of the cache files * Split GCC.yml workflow into two jobs, build_spack and build_fv3atm * Update github workflow. Add mpich * Update github actions to v4 * Use action/cache/restore in build_fv3atm job * update upp revision to 5faac75 * Update GCC.yml --------- Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
…AA-EMC#816) * update ccpp/framework * fixed excessive evaporation when both innerloop=T and mraerosol=T --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov>
…OAA-EMC#826) * Add model_configure option to specify history file output directory (fv3atm_output_dir) * Update workflows/GCC.yml * Move reading of 'fv3atm_output_dir' config option to module_wrt_grid_comp * Update upp
* Remove -DUSE_COND and -DMOIST_CAPPA compiling flags for hydrostatic runs; Fix the issue to write out omga and geopotential height for inline post * Add the conditions to calculate omega in post * Update CMakeLists.txt * revise conditions to calculate zint
…gfixes, sfcsub.F landmask bugfix, and canopy resistance output (NOAA-EMC#831) * add rca when NOAH_MP is active * fix type in GFS_typedefs.F90 for use_lake2m
…AA-EMC#807) * In ccpp/data/GFS_typedefs.meta: change units 'flashes 5 min-1' to 'flashes min-1' and update long name to make clear this is per 5 minutes * In ccpp/driver/GFS_diagnostics.F90, scale lightning threat from flashes per minute to flashes per 5 minutes to match diagnostic units * Fix wrong long names for lightning threat indices in ccpp/data/GFS_typedefs.meta * Remove invalid active attributes in ccpp/data/GFS_typedefs.meta * Bug fix for GFDL-MP in CCPP: use correct allocation of variables but internally bend everything back to where it's expected (affects some, but not all variables in CCPP_typedefs.{F90,meta}) * Bug fix in ccpp/data/GFS_typedefs.meta: sncovr_ice is always allocated, remove active attribute * Bug fix in ccpp/data/CCPP_typedefs.meta small-scale gravity wave drag variables are active for options 2,3,22,33 of gwd, not just 3,33 * Bug fix in ccpp/data/GFS_typedefs.meta: three variables are always allocated, remove active attribute * More bug fixes for active attributes in ccpp/data/GFS_typedefs.meta * More bug fixes for allocation dimensions in ccpp/data/CCPP_typedefs.*; optional arguments in stochastic_physics/stochastic_physics_wrapper.F90 * Set ccpp_data's thrd_cnt in ccpp/driver/CCPP_driver.F90 * No default in OMP pragmas in ccpp/driver/CCPP_driver.F90
* set up fhour with multiple values * updates for diag time * add fixes for two bucket * Update fhzero global attribute at runtime * Update to speed uo writing restart files * allow fhzero to be non-integer * Move ESMF_InfoBroadcast call outside ESMF_VMEpochEnter/ESMF_VMEpochExit section to avoid hanging --------- Co-authored-by: Jun.Wang <Jun.Wang@noaa.gov> Co-authored-by: Dusan Javic <dusan.javic@noaa.gov>
* Perturbation/increment file for cold starts: move the call to read_da_inc outside the if external_ic/restart logic.
…ut the nest grid corner locations (NOAA-EMC#847) * typo/bug in fv_grid_tools.F90 when print out the grid SW, NW, NE, SE CORNER indexes and lat/lon locations.
…similar to hydrostatic method (NOAA-EMC#849) * Added new parameter, pass_full_omega_to_physics_in_non_hydrostatic_mode
* HR4 GWD update for files GFS_typedefs.F90 GFS_typedefs.meta * update files GFS_typedefs.F90 GFS_typedefs.meta * remove psl_ from files GFS_typedefs.F90 GFS_typedefs.meta * HR4 Gravity Wave Drag Update * update code GFS_typedefs.F90 for GWD and Noahmp HR4 * point to PR#549 of ccpp-framework * retract the changes from the Noahmp model --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
* atmos_cubed_sphere - bug fix to address debug mode crashes caused by floating-point exception in subroutine a2b_ord2 in model/a2b_edge.F90
… in the GFS physics suite (NOAA-EMC#851) * Output updraft value of convective cloud condensate in CCPP * update xkinv1 to 0.15 * add check if progsigma is true * address seg fault if progsigma=F --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov>
* Land surface upgrades for HR4
* Update diagnose_cplFields routine to use FieldBundleWrite. Needs esmf v8.6.0 * Fixed bug in aux2d dimensions for GFS meta file. * Pass return code from diagnose_cplFields back to caller * Skip 'cpl_scalars' field when dumping export state * fix fhzero for GEFS * fix cpl_scalars (#6) * fix issues w/ cplscalars * error out of all 3 spatial indices are not present * add check for scalar_id = 0 * modify for timeslices and times (#7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs