Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSeriesAllById broken in compat mode #9

Closed
palortoff opened this issue Jul 13, 2015 · 3 comments
Closed

getSeriesAllById broken in compat mode #9

palortoff opened this issue Jul 13, 2015 · 3 comments
Assignees
Labels

Comments

@palortoff
Copy link
Contributor

Thanks for adding the zip mode!

Unfortunately, the zip mode does not seem to work in compat mode.
When calling getSeriesAllById I get
TypeError: undefined is not a function at responseOk (C:\hg\EpiNode\node_modules\node-tvdb\compat\index.js:299:14)

as the Buffer class does not have an indexOf function.
When I remove line 299, it all works...

@edwellbrook
Copy link
Owner

Hey, thanks for the heads up on this issue. If data is a Buffer, then it shouldn't reach the indexOf line in responseOk. The error seems to happen on line 299 which is if (!data) return false;. It's odd that it errors there.

Could you please provide some example code to reproduce this issue, so we can get it fixed as soon as possible! Thanks!

@edwellbrook edwellbrook self-assigned this Jul 14, 2015
@palortoff
Copy link
Contributor Author

You're right.
Somehow I only had 1.3.0. Just retried with 1.3.2.
Works fine.

Sorry about the confusion...

@edwellbrook
Copy link
Owner

Awesome. No worries at all! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants