Update some of the documentation #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remotes::install_github no longer uses repo and user Instead, guidance for repo is username/repo[/subdir][@ref|#pull|@*release] and user is deprecated.
tidyverse style guide suggests using () after all function calls to notify readers that it is a function rather than a variable place double in brackets after example to create consistency with the triple example
separate and in stead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating whisker and publishing the code on GitHub. I was going through trying to learn more about the package and noticed a few minor typos in the README and some of the functions. This pull request fixes those typos (link to Mustache, use of arguments in install_github, () for functions, and some spelling errors).
Note that I did not render the README.Rmd file to update the README.md nor did I run document() because I wasn't sure of your workflow for the README and I have a different version of roxygen2 than what was used for the package. I am happy to edit this pull request if you would like me to do those things.