Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rocos 2579 service response errors #43

Closed
wants to merge 213 commits into from
Closed

Rocos 2579 service response errors #43

wants to merge 213 commits into from

Conversation

hoani
Copy link

@hoani hoani commented Feb 10, 2021

Closes https://rocosglobal.atlassian.net/browse/ROCOS-2579

This PR addresses two issues:

  • Services causing an IO timeout
  • DynamicMessages with nil fields failing to parse JSON
    • This occurs in Services which include an empty response packet (such as turtlesim/TeleportRelative)

Changes

  • Add thorough testing to service_client
  • Add less-magic timeouts to service_client to address the IO timeout
  • Force libgengo to provide an empty slice of fields rather than a nil field for empty messages

Results:
image

Additional ticket has been added for later to address making service calls cancellable: https://rocosglobal.atlassian.net/browse/ROCOS-2580

@justinscorringe
Dynamic Services type
67db862 
Just a placeholder for actual dynamic services
@justinscorringe
Add Type() and libtest
46ba7a8
@justinscorringe
Remove fail on success
0a89826
@justinscorringe
Added comments
c80ab87
@justinscorringe
Add getSystemState api
5dcea22
@justinscorringe
Add Services api for service types
63fba53
@justinscorringe
Add serviceHeader type
cc4f79a
@justinscorringe
Merged changes from other fork
a14f57f
@justinscorringe
Fix errors
b63596c
@justinscorringe
Remove old tests
b55cf47
@justinscorringe
Fix Loggers etc
d7c16d2
@justinscorringe
Merge remote-tracking branch 'origin/DynamicServices' into Big-merge
6e6d960
@justinscorringe
Added Dynamic Services
c937b1c
@justinscorringe
Merge remote-tracking branch 'origin/Subscriber-timeout-continue' int…
e742d11 
…o Big-merge
@justinscorringe
Migration of actionlib to dynamic messages
2a6e087
@justinscorringe
Convert rest of actionlib to dynamic messages
d7552d9
@justinscorringe
State machine bytes
a753678
@justinscorringe
Remove actionlib imports
499f081
@justinscorringe
Added Dynamic_action.go
a6bf2c1
@justinscorringe
Add dynamic action unit test and fix other errors
983f190
@justinscorringe
Dynamic action child interfaces
7fe3da4
@justinscorringe
Interfaces for dynamic action message types
a806bfc
@justinscorringe
Fix dynamic message type pointer
423d3d8
@justinscorringe
Update all NewDynamicMessage instances
6053337
@justinscorringe
Changes to action type generation and serialization
f288471
@justinscorringe
Dynamic actions working
52032ba
@justinscorringe
Message functions using interface input
c8b4c97
@justinscorringe
Action error handling
63315bf
@justinscorringe
Shorten test duration
6593907
@justinscorringe
Dont return error on individual service lookup errors
40e4cc7
hoani and others added 29 commits February 4, 2021 11:21
@hoani
Add JSON Marshalling/Unmarshalling tests to ensure that custom marsha…
99da8bd 
…lling will not change behavior
@hoani
Start putting together some benchmarks
ac5ef35
@hoani
add some experimental JSON benchmarks, start breaking down the custom…
4f95920 
… marshaller
@hoani
add singular custom marshalling for dynamic message
509253c
@hoani
Add custom string encoding, include large/tiny float support
c033571
@hoani
Added json marshalling capacity preallocation, 15% improvement
d4acd9e
@hoani
Fix failing benchmark caused by change to nested structure
98e8690
@hoani
Implement custom array marshalling for dynamic messages
25b6666
@hoani
Move json functionality into a separate file for dynamic message
2d4a93d
@hoani
Add indidvisual JSON marshalling tests for primitive types
0fc08ef
@hoani
Add unmarshalling testing across all primitives, resolve unmarshal st…
42506be 
…ring bug for escape sequences
@hoani
Strengthen Dynamic Message JSON testing around strings and NaN floats
4736d94
@hoani
improve supporting tests for nested json dynamic messages
9e38068
@hoani
DynamicMessage array improvements in progress
14b67e3
@hoani
JSON unmarshal restructure and clean up
4abed70
@hoani
identified and fixed single string unmarshal bug
9997a16
@hoani
fortify dynamic message unmarshalling against runtime panics with bad…
706a841 
… data
@hoani
JSON marshal refactor and tidy ups
f4ac355
@hoani
Add dynamic message unmarshal error tests and error checks to help de…
e0b11e0 
…bug unusual unmarshal errors
@hoani
Remove experimental json benchmarking for dynamic message
d4b2901
@hoani
Additional tidy ups of comments/naming
9594980
@hoani
Use enums for determining the field built-in types in dynamic message…
a9d3fdd 
… json
Merge pull request #26 from team-rocos/ROCOS-2504_DynamicMessagingJSO…
2e46fcc 
…NMarshalling

Rocos 2504 dynamic messaging json marshalling
@hoani
Fix Dynamic Message JSON Marshalling/Unmarshalling panics for ill-for…
090e829 
…med dynamic messages
Merge pull request #27 from team-rocos/ROCOS-2504_MarshalPanicFix
a83ef22 
Fix Dynamic Message JSON Marshalling/Unmarshalling panics for ill-for…
@hoani
Get service client under test
65e5b7f
@hoani
Some minor tidy ups of service_client.go
1828e4a
@hoani
Improvements to service_client delays
afbed08
@hoani
Do not allow empty libgengo fields to equal nil
e507608
@hoani hoani closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoani @justinscorringe @flynnletford