ROC-517-Fix bug in serialization methods for dynamicmessage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra layer of folder searching for ros messages Remove extra forward slash in qualified node names
edwinhayes
reviewed
Nov 13, 2019
ros/node.go
Outdated
| @@ -149,8 +150,8 @@ func newDefaultNode(name string, args []string) (*defaultNode, error) { | |||
|
|
|||
| node.nameResolver = newNameResolver(node.namespace, node.name, remapping) | |||
| node.nonRosArgs = rest | |||
|
|
|||
| node.qualifiedName = node.namespace + "/" + node.name | |||
| // Removed additional "/" from node.qualifiedName which breaks rosgraph tests in roswtf | |||
There was a problem hiding this comment.
Don't put comments in which just explain how this version was changed; that's just source control meta-data.
edwinhayes
reviewed
Nov 13, 2019
ros/node.go
Outdated
Comment on lines
17
to
18
|
|
||
| "github.com/edwinhayes/rosgo/xmlrpc" |
There was a problem hiding this comment.
Can you find out whether this change was just accidental, or whether the IDE and Go tools did this automatically?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+Add extra layer of folder searching for ros messages
+Remove extra forward slash in qualified node names