fix: Fixing installation issues #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaisdar001
requested review from
AlasdairSwan,
abutterworth and
davidjoy
and removed request for
AlasdairSwan
awaisdar001
commented
Nov 12, 2020
| // ), | ||
| // $form-validation-states | ||
| // ); | ||
| $form-validation-states: () !default; |
There was a problem hiding this comment.
$form-validation-states variable is used at https://github.com/edx/brand-edx.org/blob/master/paragon/_overrides.scss#L68 and it should be defined.
awaisdar001
force-pushed
the
aj/branding/fix-installation-issues
branch
from
b0d8ce3
to
0705b89
Compare
|
Thanks, rebased with |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across issues while integrating
brand-edx.orgwith edx-platfrom.The first issue was wrong number of arguments for the
theme-colorfunction.I resolved the issue by passing a single argument to the function call.
Once that issue is resolved the second issue was
$form-validation-states is not defined.$form-validation-statesvariable is used at https://github.com/edx/brand-edx.org/blob/master/paragon/_overrides.scss#L68 but it was not initialized anywhere inbrand-edx.org. I observed that the variable actually exists and was commented-out in_variables.scssSee here. https://github.com/edx/brand-edx.org/blob/master/paragon/_variables.scss#L737-L750This might not be a perfect solution but it worked and I am happy to know if there are other (better) ways to address this.
TNL-7669