Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edxapp worker APM tags #21

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

nadeemshahzad
Copy link
Member

@nadeemshahzad nadeemshahzad commented May 29, 2024

the tags 'edx-edxapp-lms-workers' and 'edx-edxapp-cms-workers' are employed for logging purposes. We're adjusting these tags to align the APM tag with the logging


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@nadeemshahzad nadeemshahzad merged commit 19a6abf into master May 29, 2024
4 checks passed
@nadeemshahzad nadeemshahzad deleted the nadeem/fix-worker-apm-tags branch May 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants