feat: add list attempt api #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
commented
May 10, 2023
| re_path(fr'exam/provider_settings/course_id/{COURSE_ID_PATTERN}/exam_id/{EXAM_ID_PATTERN}', | ||
| CourseProviderSettingsView.as_view(), | ||
| name='exam-provider-settings'), | ||
| re_path( |
There was a problem hiding this comment.
refactored this so the indentation would be consistent
zacharis278
commented
May 10, 2023
zacharis278
commented
May 11, 2023
| @@ -15,16 +20,74 @@ class UserFactory(DjangoModelFactory): | |||
| class Meta: | |||
| model = get_user_model() | |||
| django_get_or_create = ( | |||
| "email", | |||
| "username", | |||
| 'email', | |||
There was a problem hiding this comment.
pylint started yelling at me about inconsistent quotes so I made everything single quote
zacharis278
commented
May 11, 2023
| is_superuser = False | ||
| is_staff = False | ||
|
|
||
|
|
||
| class ProctoringProviderFactory(DjangoModelFactory): |
There was a problem hiding this comment.
I didn't take on any refactoring with this PR but there's an opportunity to clean up a bunch of repetitive test setup using these factory classes.
zacharis278
commented
May 11, 2023
| Endpoint for listing exam attempts. Used to provide data for the instructor | ||
| facing exam dashboard. | ||
|
|
||
| /instructor_view/attempts?exam_id=<exam_id> |
There was a problem hiding this comment.
I used a unique path for this compared to exam/attempts because the data returned is different from the other attempt endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: MST-1891
Description: Adds a new endpoint to list attempts filtered by an exam id. This will drive the new 'instructor dashboard' component for exam. I expect this endpoint will include additional filter params beyond just exam_id once we add the search feature.
Using limit offset pagination allows the UI to decide it's own page size by setting the limit parameter.
Example
/instructor_view/attempts?exam_id=28&limit=20