Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating various dependencies and removing babel-polyfill #228

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

davidjoy
Copy link
Contributor

Replacing frontend-enterprise with the newer frontend-enterprise-utils. Also removing babel-polyfill in favor of core-js and regenerator-runtime.

Replacing frontend-enterprise with the newer frontend-enterprise-utils
@codecov-commenter
Copy link

Codecov Report

Merging #228 (bf2ba5e) into master (39cfad3) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   59.42%   59.13%   -0.29%     
==========================================
  Files          14       14              
  Lines         276      279       +3     
  Branches       64       67       +3     
==========================================
+ Hits          164      165       +1     
- Misses        111      113       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/Header.jsx 91.17% <ø> (+0.26%) ⬆️
src/learning-header/LearningHeader.jsx 87.50% <ø> (ø)
src/Menu/Menu.jsx 30.23% <0.00%> (-0.48%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

"@fortawesome/react-fontawesome": "^0.1.14"
"@fortawesome/react-fontawesome": "^0.1.14",
"core-js": "3.21.1",
"react-responsive": "8.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth noting that @edx/paragon (v17+) (peer dependency) exports react-responsive as a pass-thru library. See https://github.com/openedx/paragon/blob/master/docs/decisions/0014-removal-of-custom-responsive-components.rst for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants