Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix github_api to consider commits without checks as passing #12

Merged

Conversation

UsamaSadiq
Copy link
Member

Description

  • Potential solution to fix the issue reported in the DOS-4930.
  • The implemented solution can also have another approach which has been mentioned on the ticket itself.

Impact

  • Merging this solution should potentially resolve the issue where github_api doesn't return correct value pair for the commits where no checks are present. It handles the scenario where a PR with multiple commits is merged into master and GitHub only runs checks against the most recent commit but leaves the rest of the commits as it is without any actions information against them.
  • Further details and POC for the solution along with testing are present on the linked ticket.

TODO

  • If the implemented solution still doesn't work, it may be needed to set the repo merge rules to only allow squash and merge for the PRs to avoid such commits altogether on master/main branch. If the fix is successful, this follow-up step won't be needed.

@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/dos-4930-handle-missing-checks-in-commits branch 2 times, most recently from 9a41f38 to c5df9c3 Compare July 29, 2024 13:56
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/dos-4930-handle-missing-checks-in-commits branch from c5df9c3 to aaa8299 Compare July 29, 2024 14:37
@farhanumar farhanumar merged commit ab41ab5 into master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants