Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update command args for datadog-ci #5

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Jun 11, 2024

After resolving the datadog-ci command missing issue, a different issue arose where the --minified-path-prefix appears to be missing:

Missing minified path
b'Deploy frontend: Uploading source maps to Datadog for app frontend-app-learner-portal-enterprise.'
b'Deploy frontend: Could not upload source maps to Datadog for app frontend-app-learner-portal-enterprise.'

@datadog/datadog-ci source throwing that error message: https://github.com/DataDog/datadog-ci/blob/bff12e212215133d0eb59ae1814d052a2ee886c2/src/commands/sourcemaps/upload.ts#L87-L91

Turns out the command_args concatenated was missing a comma between --release-version and --minified-path-prefix.

With an added comma, it should be treated as 3 independent command arguments instead.

@adamstankiewicz adamstankiewicz marked this pull request as ready for review June 11, 2024 18:38
@adamstankiewicz adamstankiewicz changed the title fix: fix command args for datadog-ci fix: update command args for datadog-ci Jun 11, 2024
@adamstankiewicz adamstankiewicz merged commit 752a766 into master Jun 11, 2024
4 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/datadog-sourcemaps-pt3 branch June 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants