preparation for new 'grid' unit implementation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Viewport() call in gplot.hexbin()
…ginal package maintainer!
23 tasks
|
Thanks! When are you planning to commit to R-devel? |
|
There are a few more packages that we need to fix, so I think maybe only next year. The aim with this suggested fix is to take the timing out of it (the package should work both before and after we commit, without further intervention), so that we can hopefully chip away at the problems and then commit when ready. That's the aim anyway :) When do you think a new 'hexbin' might make it to CRAN ? |
|
Just submitted it! |
|
On CRAN now. |
|
Awesome. Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Thomas Lin Pedersen and I are working on a faster implementation of units in 'grid' (thomasp85/grid#14).
These changes break 'hexbin' because of the setOldClass() statement in hexViewport.R.
This PR suggests a fix that will still work on current R releases (and R-devel), but will also accommodate the new 'grid' units.
Would you consider incorporating this in 'hexbin' and at some point getting this change onto CRAN?
We are trying to eliminate as many CRAN problems as possible before we commit to R-devel.
The PR also includes a suggestion to use upViewport() rather than popViewport(), so that it is possible to navigate back to viewports that 'hexbin' has created.
Paul