Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRS cache and updated CRS print method #103

Merged
merged 10 commits into from Aug 27, 2021
Merged

CRS cache and updated CRS print method #103

merged 10 commits into from Aug 27, 2021

Conversation

rsbivand
Copy link
Contributor

No description provided.

@rsbivand
Copy link
Contributor Author

@edzer; any chance of a release? At least two packages were failing on Solaris because it runs PROJ 5.2.0 and GDAL 2.2.4, so helpfully the only CRAN instance still on proj_api.h. The fixes should help them at least a little.

@edzer
Copy link
Owner

edzer commented Jun 11, 2021

Happy to do so - have you run revdep checks using this branch / PR?

@rsbivand
Copy link
Contributor Author

rsbivand commented Jun 11, 2021

Revdeps only on my fork master branch for these commits with PROJ 5.2.0 and 8.0.1; I don't trust branches across forks. ggOceanMaps MikkoVihtakari/ggOceanMaps#6 and elevatr jhollist/elevatr#56 pass the main problems, but elevatr still fails on 5.2.0 until they stop passing st_crs()$wkt to sp::CRS() but rather pass what I suggest in the issue. They turn off testing on solaris, but lose the opportunity to test older PROJ.

@rsbivand
Copy link
Contributor Author

rsbivand commented Aug 10, 2021

Last commit to my fork to add draft vignette for package test authors suggesting how to avoid problems with platforms running old rather than new PROJ. Comments welcome. No revdeps yet.

@edzer
Copy link
Owner

edzer commented Aug 27, 2021

Let me know when I can give this a go (I mean, a merge + CRAN submission).

@rsbivand
Copy link
Contributor Author

IIRC ready to go. On the road now, so no access to revdep check logs, but don't recall problems I noticed.

@edzer
Copy link
Owner

edzer commented Aug 27, 2021

Thanks!

@edzer edzer merged commit 20e47ad into edzer:master Aug 27, 2021
@edzer
Copy link
Owner

edzer commented Aug 27, 2021

Ah, CRAN holidays...

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Dec 18, 2022
(R-sp/work/sp/inst/NEWS.Rd)
Changes in version 1.5-0 (2022-06-03):

        * merge the evolution branch from rsbivand/sp@evolution

Changes in version 1.4-7 (2022-04-18):

        * remove S-compatibility DOUBLE_* macros;
          edzer/sp#115

Changes in version 1.4-6 (2021-11-14):

        * add CRS cache and update CRS print method;
          edzer/sp#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants