Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.4 (was 2.13.3) #42

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Conversation

SethTisue
Copy link

@SethTisue SethTisue commented Jan 12, 2021

opening the PR not because I intend to finish it myself, but to notify you of the test failures, which I also saw in the Scala community build

@eed3si9n
Copy link
Owner

@SethTisue Thanks Seth!

@keynmol keynmol self-assigned this Jan 18, 2021
@keynmol
Copy link
Collaborator

keynmol commented Jan 19, 2021

I'm going to look into it.

Only culprit I can think of is -Yrangepos being on by default in 2.13.4. That said, I haven't yet found exactly the place where this takes effect.

Sadly I'll have to fix this as Native 0.4.0 just dropped and one of its components only published for 2.13.4 :D

Behaviour seems to align with Scala 3.
Could it be scala/scala#9208 ?
@Baccata
Copy link
Collaborator

Baccata commented Jan 20, 2021

Tests are green, some behaviour in 2.13.4 around List() now aligns with 3.0.0-Mx for some reason. Because of this alignment, I'm choosing not to dive into the rabbit-hole of investigating the why.

@Baccata Baccata marked this pull request as ready for review January 20, 2021 22:00
@eed3si9n eed3si9n merged commit bd21f65 into eed3si9n:develop Jan 20, 2021
@SethTisue SethTisue deleted the scala-2.13.4 branch January 20, 2021 22:37
@SethTisue
Copy link
Author

SethTisue commented Jan 20, 2021

scala/community-build@fb0a4de 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants