Add zapFile rule type
#49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analogous to `zap` rule type, which only allows for omitting `.class` files, this change adds a `zapFile` type that will omit any file based on the path and wildcarding support available to other rules. Fixes: #48
|
Sorry I didn't comment on this PR. I noticed the PR was red in CI and didn't check back. I did appreciate your contribution and I think it would be nice to have general file processing abilities in the code. |
|
@johnynek I've moved on from the company where this change was relevant, so it's no longer "my problem to worry about"™️. I was just cleaning up things that I was not going to come back to and the PR closure had nothing to do with the repo codeowners 😄 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to
zaprule type, which only allows for omitting.classfiles, this change adds azapFiletype that will omit any file based on the path and wildcarding support available to other rules.Fixes: #48