Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make read_json_value handle "true" and "false" #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ziggythehamster
Copy link

When I was attempting to push my docs back to CouchDB, I found that
some of my design documents had certain properties serialized as
literally "false" or "true". I don't necessarily disagree with that,
but then the JSON parser complains. So this makes it return false or
true when that's all in the file, which makes my docs import as
expected.

If there's a cleaner way to fix this, please let me know and I'll
submit a better patch :)

When I was attempting to push my docs back to CouchDB, I found that
some of my design documents had certain properties serialized as
literally "false" or "true". I don't necessarily disagree with that,
but then the JSON parser complains. So this makes it return false or
true when that's all in the file, which makes my docs import as
expected.

If there's a cleaner way to fix this, please let me know and I'll
submit a better patch :)
@eee-c
Copy link
Owner

eee-c commented Oct 5, 2012

Thanks for the PR! Can you make sure that the specs still pass? I'll try to have a look myself when I get a chance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants