Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require quotes for implicit keys with flow indicators #494

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

eemeli
Copy link
Owner

@eemeli eemeli commented Aug 26, 2023

Fixes #493

The oddity here turned out to be in part caused by a mismatch in the YAML spec text & rules; I've filed yaml/yaml-spec#313 to add an errata for that. See there for more technical details, but the fix required here is removing one part of the check in the stringifier. I'd followed the YAML rules for the parser, but the YAML text for the stringifier, and the latter was wrong.

@eemeli eemeli merged commit 9558e96 into main Aug 28, 2023
14 checks passed
@eemeli eemeli deleted the fix-implicit-plain-key-string branch August 28, 2023 14:29
@rattrayalex
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to plain-format some keys like /models/{model}
2 participants