Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the lineWidth option for line breaking in flow collections #522

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: use the lineWidth option for line breaking in flow collections #522

merged 1 commit into from
Feb 15, 2024

Conversation

no92
Copy link
Contributor

@no92 no92 commented Feb 12, 2024

This should address issues #288 and #507.

eemeli
eemeli requested changes Feb 13, 2024
View reviewed changes
Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising! Should include an additional test or three to exercise the option. Also, see inline comment.

src/stringify/stringifyCollection.ts Outdated Show resolved Hide resolved
@no92
Copy link
Contributor Author

no92 commented Feb 13, 2024

I also amended the commit to include two testcases, with one that wraps and another test that does not.

@eemeli eemeli merged commit 9a8aa0d into eemeli:main Feb 15, 2024
13 checks passed
@no92 no92 deleted the line-breaking-fix branch February 15, 2024 11:41
@eemeli eemeli mentioned this pull request Feb 24, 2024
Closed
@hedera-eng-infrastructure hedera-eng-infrastructure mentioned this pull request Mar 27, 2024
Closed
@scamcloud scamcloud mentioned this pull request May 19, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request May 24, 2024
Merged
@caniszczyk caniszczyk mentioned this pull request May 30, 2024
Closed
@paaschdigital paaschdigital mentioned this pull request Jun 8, 2024
Open
@richb-hanover richb-hanover mentioned this pull request Jun 9, 2024
Closed
@richb-hanover richb-hanover mentioned this pull request Jun 23, 2024
Closed
@caniszczyk caniszczyk mentioned this pull request Jun 27, 2024
Closed
@DeFiTON DeFiTON mentioned this pull request Jun 30, 2024
Open
@blixtra blixtra mentioned this pull request Jun 30, 2024
Closed
eemeli added a commit that referenced this pull request Jul 7, 2024
@eemeli
chore: Drop unused Collection.maxFlowStringSingleLineLength (see #522, …
f73e1d9 
…closes #421)
@WontonSam WontonSam mentioned this pull request Jul 19, 2024
Open
@LTomer LTomer mentioned this pull request Jul 23, 2024
Open
@schwer schwer mentioned this pull request Jul 26, 2024
Closed
@2lambda123 2lambda123 mentioned this pull request Aug 14, 2024
Merged
@DeFiTON DeFiTON mentioned this pull request Aug 15, 2024
Open
@fgarcia fgarcia mentioned this pull request Aug 15, 2024
Open
@beekoticf beekoticf mentioned this pull request Aug 15, 2024
Merged
@dragos-cojocari dragos-cojocari mentioned this pull request Aug 15, 2024
Open
@rexiliano89 rexiliano89 mentioned this pull request Aug 21, 2024
Open
@Sec32fun32 Sec32fun32 mentioned this pull request Sep 2, 2024
Open
@schwer schwer mentioned this pull request Sep 6, 2024
Merged
@dragos-cojocari dragos-cojocari mentioned this pull request Sep 7, 2024
Open
@fgarcia fgarcia mentioned this pull request Sep 10, 2024
Closed
@psturc psturc mentioned this pull request Sep 24, 2024
Open
@supriza supriza mentioned this pull request Sep 25, 2024
Merged
@mahaabid2001 mahaabid2001 mentioned this pull request Sep 25, 2024
Open
@fgarcia fgarcia mentioned this pull request Sep 25, 2024
Merged
@beekoticf beekoticf mentioned this pull request Sep 25, 2024
Merged
@2lambda123 2lambda123 mentioned this pull request Sep 25, 2024
Merged
@AKJUS AKJUS mentioned this pull request Sep 25, 2024
Open
@minsiyang minsiyang mentioned this pull request Sep 26, 2024
Merged
@WontonSam WontonSam mentioned this pull request Oct 14, 2024
Open
@Graysonbarton Graysonbarton mentioned this pull request Oct 15, 2024
Open
@tunnckoCore tunnckoCore mentioned this pull request Oct 27, 2024
Open
@suculent suculent mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no92 @eemeli