-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trouble with Prember & AddonDocs #36
Comments
Installing |
Next question: AddonDocs does some clever rewriting of rootURL. In production we set it to a token This is giving Prember trouble when its trying to prerender dynamic routes. Is it possible to see, from
but |
👋 I'm really glad you're trying out prember for addon-docs because I've always thought it was a perfect fit 😍 I took a quick look at this myself locally and I see your issue where it's trying to request http://localhost:7784/ADDON_DOCS_ROOT_URL/docs/prember-addon-test.json during the prember build 🤔 I wonder though, would this not also be an issue during a "regular" fastboot render? It may just be the nature of the things that I have been working on with prember but any time I need to do anything different in the prember render I tend to just use the normal semantics to check if you're in fastboot |
Yes, what Chris said. Prember is not a special mode, it’s just a convenient
way to call regular old fastboot during the ember-cli build.
So in general make things work for fastboot first and then just use prember
at the end.
…On Thu, Feb 21, 2019 at 4:14 AM Chris Manson ***@***.***> wrote:
👋 I'm really glad you're trying out prember for addon-docs because I've
always thought it was a perfect fit 😍
I took a quick look at this myself locally and I see your issue where it's
trying to request
http://localhost:7784/ADDON_DOCS_ROOT_URL/docs/prember-addon-test.json
during the prember build 🤔 I wonder though, would this not also be an
issue during a "regular" fastboot render?
It may just be the nature of the things that I have been working on with
prember but any time I need to do anything different in the *prember*
render I tend to just use the normal semantics to check if you're in
fastboot this.fastboot.isFastBoot or whatever it is 😂
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#36 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATfMvOnUk3EAqykBPQCWoFzIGf4Mngrks5vPmNcgaJpZM4bFaAs>
.
|
Y'all are correct. We use the Chatted with @dfreeman about this and I think we probably should remove this "abstraction" of ours, as tools like FastBoot and others (asset map, etc.) all use Thanks so much for Prember, it is very, very cool! |
I'm new to Prember and I'm trying to get it working with Mirage's AddonDocs site.
I hit this error after installing
prember-middleware
and runningPREMBER=true ember serve
:I think it has to do with
ember-fetch
, adependency
from AddonDocs.I found this issue from
ember-fetch
but it seems the bug was fixed in the latest version. When Iyarn why ember-fetch
I see that my project is using 6.4.0, the latest version.Any ideas what's going on?
I have a simplified reproduction repo here.
Full stack trace
The text was updated successfully, but these errors were encountered: