Tweak Classic Flow's Antenna Insertion Regime
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `Classic` flow
* `Odb.HeuristicDiodeInsertion` now runs after `OpenROAD.RepairDesignPostGRT` (as the latter may create some long wires)
* `OpenROAD.CheckAntennas` added after `OpenROAD.DetailedRoute`
* Part of `OpenROAD.GlobalRouting` spun off as `OpenROAD.RepairAntennas`
* Removed `GRT_REPAIR_ANTENNAS`
* Added `OpenROAD.RepairAntennas` to `Classic` flow after `OpenROAD.ResizerTimingPostGRT`; gated by `RUN_ANTENNA_REPAIR` (with a deprecated name of `GRT_REPAIR_ANTENNAS` for backwards compat)
* Internally updated implementation of `VHDLClassic` flow to dynamically create `.Steps` from `Classic`
Closed
donn
added
the
⛔️ blocked
donn
removed
the
⛔️ blocked
This was referenced Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
kareefardi
reviewed
Nov 9, 2023
Merged
kareefardi
requested changes
Nov 14, 2023
kareefardi
approved these changes
Nov 15, 2023
donn
added a commit
to The-OpenROAD-Project/OpenLane
that referenced
this pull request
Nov 19, 2023
~ `openroad_app` -> `6f9b2bb` to match efabless/openlane2#255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassicflowOdb.DiodesOnPortsandOdb.HeuristicDiodeInsertionnow run afterOpenROAD.RepairDesignPostGRT(as the latter may create some long wires) but still beforeOdb.ResizerTimingPostGRT(as timing repairs take priority)OpenROAD.CheckAntennasadded afterOpenROAD.DetailedRouteOpenROAD.GlobalRoutingspun off asOpenROAD.RepairAntennasOpenROAD.RepairAntennastoClassicflow afterOdb.HeuristicDiodeInsertion; gated byRUN_ANTENNA_REPAIR(with a deprecated name ofGRT_REPAIR_ANTENNASfor backwards compat)GRT_REPAIR_ANTENNASfrom the step itselfOdb.DiodesOnPorts,Odb.HeuristicDiodeInsertion:Odb.PortDiodePlacementandOdb.FuzzyDiodeInsertion.HEURISTIC_ANTENNA_THRESHOLDto be a non-optional PDK variable with default variables added inopenlane/config/pdk_compat.pyVHDLClassicflow to dynamically create.StepsfromClassicopenlane.config.Variable::Variable.pdkto make it a bit clearer6f9b2bbopenroad-abcfor modularity purposesantenna__counttoroute__antenna_violations__countResolves #248
Blocked on The-OpenROAD-Project/OpenROAD#4229