-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenROAD Unit Tests #244
OpenROAD Unit Tests #244
Conversation
add openroad.ioplacement unit tests warn when skipping openroad.ioplacement
add openroad patch for -no_merge_via_res
set FP_PDN_CFG inside python step not in the tcl script
openlane/steps/step.py
Outdated
@@ -721,7 +722,7 @@ def filename_with_counter(): | |||
dumpable_config = copy_recursive(self.config, translator=visitor) | |||
dumpable_config["meta"] = { | |||
"openlane_version": __version__, | |||
"step": self.__class__.id, | |||
"step": self.__class__.id.rstrip("-0123456789"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge #255 we could just use _original_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_original_id
is only returned by method with_id
. How should I utilize that here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess in __init_subclass__
we can check if the class hasattr _original_id
and if not, we just set it to the id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is self.__class__.id
varies when in a flow there a step is repeated. I am not sure where this happens but perhaps at that point _original_id
could be set to id without numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I… implemented something
remove openroad patch do not use hardcode paths in os.path.join
OpenROAD.CheckAntennas
OpenROAD.DetailedPlacement
OpenROAD.DetailedRouting
OpenROAD.FillInsertion
OpenROAD.Floorplan
OpenROAD.GeneratePDN
OpenROAD.GlobalPlacement
OpenROAD.IOPlacement
OpenROAD.RCX
OpenROAD.TapDecapInsertion
OpenROAD.IOPlacement
when a custom io config is set.FP_PDN_CFG
inside the python interface not inside OpenROAD tcl script--keep-tmp
for step tests to preserve the test tmp directory.Depends on:
efabless/openlane2-step-unit-tests#7