Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenROAD Unit Tests #244

Merged
merged 28 commits into from
Nov 16, 2023
Merged

OpenROAD Unit Tests #244

merged 28 commits into from
Nov 16, 2023

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Oct 31, 2023

  • Added tests for the following OpenROAD steps:
    • OpenROAD.CheckAntennas
    • OpenROAD.DetailedPlacement
    • OpenROAD.DetailedRouting
    • OpenROAD.FillInsertion
    • OpenROAD.Floorplan
    • OpenROAD.GeneratePDN
    • OpenROAD.GlobalPlacement
    • OpenROAD.IOPlacement
    • OpenROAD.RCX
    • OpenROAD.TapDecapInsertion
  • Added warning when skipping OpenROAD.IOPlacement when a custom io config is set.
  • Set FP_PDN_CFG inside the python interface not inside OpenROAD tcl script
  • Test infrastructure: Added --keep-tmp for step tests to preserve the test tmp directory.

Depends on:
efabless/openlane2-step-unit-tests#7

@kareefardi kareefardi mentioned this pull request Oct 31, 2023
1 task
@kareefardi kareefardi marked this pull request as ready for review November 14, 2023 10:33
nix/openroad.nix Outdated Show resolved Hide resolved
openlane/logging/logger.py Outdated Show resolved Hide resolved
openlane/steps/openroad.py Outdated Show resolved Hide resolved
@@ -721,7 +722,7 @@ def filename_with_counter():
dumpable_config = copy_recursive(self.config, translator=visitor)
dumpable_config["meta"] = {
"openlane_version": __version__,
"step": self.__class__.id,
"step": self.__class__.id.rstrip("-0123456789"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge #255 we could just use _original_id

Copy link
Collaborator Author

@kareefardi kareefardi Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_original_id is only returned by method with_id. How should I utilize that here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess in __init_subclass__ we can check if the class hasattr _original_id and if not, we just set it to the id?

Copy link
Collaborator Author

@kareefardi kareefardi Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is self.__class__.id varies when in a flow there a step is repeated. I am not sure where this happens but perhaps at that point _original_id could be set to id without numbers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I… implemented something

test/conftest.py Show resolved Hide resolved
@donn donn changed the title OpenROAD unit tests OpenROAD Unit Tests Nov 16, 2023
@donn donn merged commit 4c7deb4 into main Nov 16, 2023
75 checks passed
@donn donn deleted the openroad-unit-tests branch November 16, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants