Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIP-8: POAP DIP #19

Merged
merged 12 commits into from
Sep 3, 2020
Merged

DIP-8: POAP DIP #19

merged 12 commits into from
Sep 3, 2020

Conversation

poapxyz
Copy link
Contributor

@poapxyz poapxyz commented Aug 17, 2020

No description provided.

DIPs/POAP-DIP.md Outdated Show resolved Hide resolved
DIPs/POAP-DIP.md Outdated Show resolved Hide resolved
DIPs/POAP-DIP.md Outdated Show resolved Hide resolved
DIPs/POAP-DIP.md Outdated Show resolved Hide resolved
DIPs/POAP-DIP.md Outdated Show resolved Hide resolved
DIPs/POAP-DIP.md Outdated Show resolved Hide resolved
DIPs/POAP-DIP.md Outdated Show resolved Hide resolved
poapxyz and others added 6 commits August 18, 2020 10:26
Co-authored-by: ligi <ligi@ligi.de>
Co-authored-by: ligi <ligi@ligi.de>
Co-authored-by: ligi <ligi@ligi.de>
Co-authored-by: ligi <ligi@ligi.de>
Co-authored-by: ligi <ligi@ligi.de>
Co-authored-by: ligi <ligi@ligi.de>
@ligi
Copy link
Member

ligi commented Aug 20, 2020

thanks for adapting the proposed changes. What is still missing is not to delete DIP-0, renaming to DIP-8.md and correct markdown for the headings (##)

@ligi ligi changed the title POAP DIP DIP-8: POAP DIP Aug 20, 2020
@poapxyz poapxyz requested a review from ligi August 24, 2020 00:31
@ligi
Copy link
Member

ligi commented Sep 3, 2020

sorry for the delayed merge - we are still fleshing out the rough edges of this brand new process. Good thing is that we still have some time to DevCon ;-)
We now have a checklist and I will go through it - once all is checked we will merge.

  • Correct markdown (e.g. headers with ##, header surrounded by ---)
  • syntax check
  • filename is DIP-X.md (with X being the correct DIP number)
  • header contains (in this order)
    • DIP
    • Title
    • Status
    • Theme(s)
    • Tag(s)
    • Author(s)
    • Resources Required (optional)
    • Discussion-to (with link to devcon forum)
    • Created (in the format year-month-day e.g 2020-4-20)
  • contains these sections:
    • Abstract
    • Rationale
    • Implementation
    • Operational Reuirements & Ownership
  • PR title prefixed with DIP-X

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ligi ligi merged commit 700f11a into efdevcon:master Sep 3, 2020
@vae799
Copy link

vae799 commented Aug 23, 2021

???????????????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants