-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PineTab (aka Quirky Devices) #15
Comments
This commit adds a bunch of features, including: * Use the correct accelerometer value scale Not all devices have the accelerometer raw value between 0 and 1 (e.g. PineTab). The current scale is accessible via sysfs. * Revamped keyboard mode system You can specify how your keyboard is attached so that rot8 will do the appropriate thing. `--keyboard-mode` can be one of: - `integral`: The keyboard is an integral part of the device. We will disable the keyboard when the screen is not oriented upright. - `detachable`: The keyboard is detachable. We will keep the screen oriented upright when the keyboard is attached. - `none`: We won't touch your keyboard. The old `-k`/`--disable-keyboard` flag has been removed. * After-rotation hook Specify a command to be run in shell after rotation with `--rotate-hook`. Useful for forcing a restart of Polybar, for example. * PineTab-specific flags There are several PineTab-specific additions. If you are using a PineTab, the following flags should be given: --display DSI-1 --touchscreen 'pointer:Goodix Capacitive TouchScreen' --flip-y --rotate-90 --keyboard-mode detachable --keyboard 'HAILUCK CO.,LTD USB KEYBOARD' If you are setting the default rotation in Xorg.conf, use `TransformationMatrix` instead of `CalibrationMatrix` for the touchscreen, otherwise the setting will conflict with rot8. Issue: efernau#15
This commit adds a bunch of features, including: * Use the correct accelerometer value scale Not all devices have the accelerometer raw values between 0 and 1 (e.g. PineTab). The correct scale is accessible via sysfs. * Revamped keyboard mode system You can specify how your keyboard is attached so that rot8 will do the appropriate thing. `--keyboard-mode` can be one of: - `integrated`: The keyboard is an integral part of the device. We will disable the keyboard when the screen is not oriented upright. - `detachable`: The keyboard is detachable. We will keep the screen oriented upright when the keyboard is attached. - `none`: We won't touch your keyboard. The old `-k`/`--disable-keyboard` flag has been removed. * After-rotation hook Specify a command to be run in shell after rotation with `--rotate-hook`. Useful for forcing a restart of Polybar, for example. * PineTab-specific flags There are several PineTab-specific additions. If you are using a PineTab, the following flags should be given: --display DSI-1 --touchscreen 'pointer:Goodix Capacitive TouchScreen' --flip-y --rotate-90 --keyboard-mode detachable --keyboard 'HAILUCK CO.,LTD USB KEYBOARD' If you are setting the default rotation in Xorg.conf, use `TransformationMatrix` instead of `CalibrationMatrix` for the touchscreen, otherwise the setting will conflict with rot8. Issue: efernau#15
Still WIP, but I've made some changes to accommodate PineTab and similar devices: Use the correct accelerometer value scaleNot all devices have the accelerometer raw values between 0 and 1 (e.g. PineTab). The correct scale is accessible via sysfs. Revamped keyboard mode systemI added
After-rotation hook (#4)You can specify a command to be run in shell after rotation with |
I also have issues with the accelerometer value scale. For my hw (Lenovo Yoga 920), I believe all that's necessary is to replace Lines 260 to 262 in b7b42d9
Edit: Actually, it should be |
thanks for your commit, sadly not merged. |
So I recently got a PineTab, which is an ARM tablet with a detachable keyboard dock (see picture, the magnetic connector is actually USB). It has the following quirks:
The native orientation is rotated by 90 degrees
(Yes, that's the native resolution - 800x1280)
Because we use the
normal
orientation to decide whether to enable the keyboard, we need toActually, as the keyboard can be detached, we should have a feature where we lock the rotation to the normal human orientation when an input device is present (in this case, the USB keyboard).
Edit: Wanted to set up everything again half a year later, and saw this silliness. Please, ignore my brain fart 😆 There is no need to normalize anything, or flip the axes. In fact, the current code in
src/main.rs
is over-complicating the thing by comparing the vectors.The text was updated successfully, but these errors were encountered: