-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi-line extern
definitions ; LLVM stdlib
#138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wait the changes look good to me (without looking too much into the regex). However, the tests still fail.
@jfrech Please don't merge until the tests run through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail.
@b-studios Yes, a lot of tests fail. I suspect a lexer ordering issue, yet could not come up with a fix. |
The failure of the Apparently the test was flaky. Rerunning it went through. |
@jfrech Could you resolve the merge conflicts? Then we are ready to merge this PR. |
@jfrech When you merge, can you create a merge commit? |
@b-studios I would, yet am underprivileged. |
No description provided.