Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-line extern definitions ; LLVM stdlib #138

Merged
merged 6 commits into from
Sep 23, 2022

Conversation

jfrech
Copy link
Collaborator

@jfrech jfrech commented Sep 15, 2022

No description provided.

@jfrech jfrech mentioned this pull request Sep 15, 2022
Copy link
Collaborator

@b-studios b-studios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wait the changes look good to me (without looking too much into the regex). However, the tests still fail.

@jfrech Please don't merge until the tests run through.

Copy link
Collaborator

@b-studios b-studios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail.

@jfrech
Copy link
Collaborator Author

jfrech commented Sep 22, 2022

@b-studios Yes, a lot of tests fail. I suspect a lexer ordering issue, yet could not come up with a fix.

@b-studios
Copy link
Collaborator

b-studios commented Sep 23, 2022

The failure of the anf.md test is strange. It does work on my machine.

Apparently the test was flaky. Rerunning it went through.

@b-studios
Copy link
Collaborator

@jfrech Could you resolve the merge conflicts? Then we are ready to merge this PR.

@b-studios
Copy link
Collaborator

@jfrech When you merge, can you create a merge commit?

@jfrech
Copy link
Collaborator Author

jfrech commented Sep 23, 2022

@b-studios I would, yet am underprivileged.

@phischu phischu merged commit 5fa89a2 into master Sep 23, 2022
@phischu phischu deleted the feature/multiline-extern-definitions branch September 23, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants