Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend interfaces #234

Merged
merged 14 commits into from
Feb 18, 2023
Merged

Refactor backend interfaces #234

merged 14 commits into from
Feb 18, 2023

Conversation

b-studios
Copy link
Collaborator

Adresses #233

@b-studios
Copy link
Collaborator Author

b-studios commented Feb 17, 2023

There is still a few things to do:

  • Merge Compiler and BackendCompiler into one trait
  • Rename BackendRunner into Runner
  • Drop generator.Backend
  • Inline the pipelines of the backends into the respective compilers
  • Move compilers to respective folders
  • Factor out Backend file which serves as a main entry point for documentation.
  • Move effekt.llvm to effekt.generator.llvm
  • turn Stage into a GADT and abstract over pretty printing the intermediate IRs. this way we can cut down the interface to one, only.
  • test with website

@b-studios
Copy link
Collaborator Author

It is starting to look better. One thing that I still don't like is the Either[String, Unit]... Maybe we should throw an exception instead?

@b-studios b-studios changed the title Refactor/backend refactoring Refactor backend interfaces Feb 18, 2023
@b-studios b-studios merged commit 232b177 into master Feb 18, 2023
@b-studios b-studios deleted the refactor/backend-refactoring branch February 18, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant