Allow identification of type of PathOrContent #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
bwplotka
requested changes
Aug 17, 2022
extkingpin/pathorcontent.go
Outdated
Comment on lines
102
to
107
| func (p *PathOrContent) Path() string { | ||
| if p.path != nil { | ||
| return *p.path | ||
| } | ||
| return "" | ||
| } |
There was a problem hiding this comment.
Suggested change
| func (p *PathOrContent) Path() string { | |
| if p.path != nil { | |
| return *p.path | |
| } | |
| return "" | |
| } | |
| func (p *PathOrContent) Path() string { | |
| return *p.path | |
| } |
This is enough.
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Douglas Camata 159076+douglascamata@users.noreply.github.com
I wanted to integrate
extkingpin.PathOrContentwith https://github.com/fsnotify/fsnotify to reload configuration when a path is used and the indicated file changes, but it's not achievable without this.