Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new cards #286

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Feature/new cards #286

merged 4 commits into from
Aug 5, 2022

Conversation

sofusalbertsen
Copy link
Contributor

No description provided.

@sofusalbertsen
Copy link
Contributor Author

@Kargamborgh Can I get you to verify that the id's of cards can be anything, or should I take the ID's from somewhere?

Copy link
Contributor

@vuuan vuuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lint the file and check that there are same amount of starting and closing curly brackets

@sofusalbertsen
Copy link
Contributor Author

Could see that I made a bad commit, messing things up.
Will see what GHA says now.

@sofusalbertsen sofusalbertsen temporarily deployed to dev August 4, 2022 08:40 Inactive
@sofusalbertsen
Copy link
Contributor Author

@vuuan I would like this to be deployed to dev first to see if the card ID's given are something that is okay to have or not. Can you help out?

@sofusalbertsen sofusalbertsen requested review from vuuan and removed request for Kargamborgh and vuuan August 4, 2022 11:36
Copy link
Contributor

@vuuan vuuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@vuuan vuuan merged commit 98e1978 into main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants